Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve tendermint withdraws #15

Merged
merged 5 commits into from
Dec 9, 2024
Merged

Fix and improve tendermint withdraws #15

merged 5 commits into from
Dec 9, 2024

Conversation

smk762
Copy link
Contributor

@smk762 smk762 commented Nov 27, 2024

This PR adds a warning for Tendermint withdrawals, and adjusts the layout of the send form to include optional IBC channel ID input.

To Test:

  • Login and go to send some Tendermint coins
  • See warnings about IBC transfers to CEX
  • Send tendermint coin with non-IBC transfer (same chain/address format)
  • Send tendermint coin with IBC transfer but without custom IBC channel
  • Send tendermint coin with IBC transfer and with custom IBC channel
  • Confirm link to IBC channel info working
  • Test transactions with some other coins to confirm no regression (with/without custom fees & memos)

@smk762 smk762 added bug Something isn't working P0 Major bug to be fixed labels Nov 27, 2024
cipig
cipig approved these changes Dec 7, 2024
View reviewed changes
Copy link
Member

@cipig cipig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the fix
IRIS withdraws now work fine
image
Sometimes one of the RPCs returns an error, but sends the tx anyway (bg color of error message is fixed):
image

idk which of them returns the error, i have this in my config for IRIS:

            {
                "url": "https://iris-rpc.alpha.komodo.earth/",
                "api_url": "https://iris-api.alpha.komodo.earth/",
                "grpc_url": "https://iris-grpc.alpha.komodo.earth/",
                "ws_url": "wss://iris-rpc.alpha.komodo.earth/websocket"
            },
            {
                "url": "https://rpc.irishub-1.irisnet.org"
            }

anyway, this is not related to the fix, but to the RPC endpoint

@cipig
Copy link
Member

cipig commented Dec 8, 2024

the time out comes from https://iris-rpc.alpha.komodo.earth, the tx is sent anyway
the other RPC endpoint is even worse, it shows a fee error and does not send anything
guess we need to find some other/more endpoints
what about the ones from https://github.com/cosmos/chain-registry/blob/master/irisnet/chain.json ?

@cipig
Copy link
Member

cipig commented Dec 8, 2024

tried a second public RPC and i get same error as with https://rpc.irishub-1.irisnet.org
image

does our endpoint, https://iris-rpc.alpha.komodo.earth have anything special configured in regards to the txfees?

@smk762
Copy link
Contributor Author

smk762 commented Dec 9, 2024

tried a second public RPC and i get same error as with https://rpc.irishub-1.irisnet.org image

does our endpoint, https://iris-rpc.alpha.komodo.earth have anything special configured in regards to the txfees?

minimum-gas-prices = "0.001uiris"
enable-fee-suggestion = false
gas-to-suggest = 200000
denom-to-suggest = "uiris"

in app.toml

@smk762 smk762 merged commit f64b0eb into dev Dec 9, 2024
4 of 6 checks passed
@cipig
Copy link
Member

cipig commented Dec 9, 2024

funny is that swaps work with the public endpoint... on my makers i only have https://rpc.irishub-1.irisnet.org configured... when i use the same on Desktop (also tried a second public RPC) i get the error about the fees on withdraws
it works with our own RPC, even though that one often shows a timeout when sending, but the tx is sent anyway

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cipig cipig cipig approved these changes

@AndrewDelaney AndrewDelaney AndrewDelaney approved these changes

@shamardy shamardy Awaiting requested review from shamardy

@ShantanuSharma9873 ShantanuSharma9873 Awaiting requested review from ShantanuSharma9873

Assignees
No one assigned
Labels
bug Something isn't working P0 Major bug to be fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@smk762 @cipig @AndrewDelaney